mimaison commented on code in PR #13257: URL: https://github.com/apache/kafka/pull/13257#discussion_r1231157115
########## docs/ops.html: ########## @@ -3550,14 +3550,14 @@ <h5 class="anchor-heading"><a id="kraft_shell_tool" class="anchor-link"></a><a h <h4 class="anchor-heading"><a id="kraft_deployment" class="anchor-link"></a><a href="#kraft_deployment">Deploying Considerations</a></h4> <ul> - <li>Kafka server's <code>process.role</code> should be set to either <code>broker</code> or <code>controller</code> but not both. Combined mode can be used in development enviroment but it should be avoided in critical deployment evironments.</li> - <li>For redundancy, a Kafka cluster should use 3 controllers. More than 3 servers is not recommended in critical environments. In the rare case of a partial network failure it is possible for the cluster metadata quorum to become unavailable. This limitation will be addresses in a future release of Kafka.</li> + <li>Kafka server's <code>process.role</code> should be set to either <code>broker</code> or <code>controller</code> but not both. Combined mode can be used in development environments, but it should be avoided in critical deployment environments.</li> + <li>For redundancy, a Kafka cluster should use 3 controllers. More than 3 servers is not recommended in critical environments. In the rare case of a partial network failure it is possible for the cluster metadata quorum to become unavailable. This limitation will be addressed in a future release of Kafka.</li> Review Comment: Should `More than 3 servers is not recommended in critical environments.` be `More than 3 controllers is not recommended in critical environments.`? Otherwise it could be interpreted as "you can only have 3 brokers" ########## docs/ops.html: ########## @@ -3569,7 +3569,7 @@ <h4 class="anchor-heading"><a id="kraft_missing" class="anchor-link"></a><a href <h4 class="anchor-heading"><a id="kraft_zk_migration" class="anchor-link"></a><a href="#kraft_zk_migration">ZooKeeper to KRaft Migration</a></h4> <p> - <b>The ZooKeeper to KRaft migration feature is considered Early Access in 3.4.0. It is not recommended for production clusters.</b> + <b>ZooKeeper to KRaft migration is considered an Early Access feature in 3.4.0 and is not recommended for production clusters.</b> Review Comment: Should we remove `in 3.4.0` from this sentence? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org