[ https://issues.apache.org/jira/browse/KAFKA-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467020#comment-16467020 ]
Jiangjie Qin commented on KAFKA-2200: ------------------------------------- [~PnPie] Sorry about the belated response. Yes, you are right, I don't think the TimeoutException on waiting for metadata is an ApiException. That is a pure client side behavior. RecordTooLargeException is a little trickier, conceptually it is an ApiException, but the producer may throw it without talking to the server. I wonder if it is simpler to just throw an IllegalArgumentException when the records are too large in producer.send() if we want to make sure all the ApiExceptions are handled in the callback. > kafkaProducer.send() should not call callback.onCompletion() > ------------------------------------------------------------ > > Key: KAFKA-2200 > URL: https://issues.apache.org/jira/browse/KAFKA-2200 > Project: Kafka > Issue Type: Bug > Components: clients > Affects Versions: 0.10.1.0 > Reporter: Jiangjie Qin > Priority: Major > Labels: newbie > Fix For: 2.0.0 > > > KafkaProducer.send() should not call callback.onCompletion() because this > might break the callback firing order. -- This message was sent by Atlassian JIRA (v7.6.3#76005)