dajac commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1217620168
##########
clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java:
##########
@@ -131,6 +131,7 @@ public Map<Errors, Integer> errorCounts() {
public static final class PartitionResponse {
public Errors error;
public long baseOffset;
+ public long lastOffset;
Review Comment:
Yeah, it is usually the case. Ss we don't use the auto-generated classes
here (yet), we can do this.
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -1066,9 +1066,6 @@ class ReplicaManager(val config: KafkaConfig,
requiredAcks == -1 || requiredAcks == 1 || requiredAcks == 0
}
- /**
- * Append the messages to the local replica logs
Review Comment:
Removed it by mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
