vamossagar12 commented on PR #13504: URL: https://github.com/apache/kafka/pull/13504#issuecomment-1569680586
@C0urante , going by the update from Deng above, we will have to live with a fix like this for some time. That still has the question of the ACL requirements for the new Sink task. Since you called it out as a breaking change needing a KIP, we still need to get around that. I can see 2 options => 1) We wait for the upcoming major release and start with a KIP. 2) We go ahead and try to fix this behaviour for cases when there's ACL configured or the Admin user has the access to describe topic. For such cases it would work and we should be good. In case the describeTopics call fails let's say due to a `ClusterAuthorizationException`, `TopicAuthorizationException`(wrapped in `ConnectException`), and if we assume that the topic exists, then we still won't have the position computed for that topic partition. Which means we can't update anything in `lastCommittedOffsets` and `currentOffsets` (eventually `sinkTaskMetricsGroup`) which is still an inconsistent state I feel. What if we throw the exception and add a log line to consider adding ACL to describe topic for the admin user ? Is something like that acceptable? Note that, the consolidation of the admin client for SinkTasks is still pending on me. But before that I wanted to know what the next steps should be on this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
