[GitHub] [kafka] jlprat commented on a diff in pull request #13723: KAFKA-14980: Fix MirrorSourceConnector source consumer configuration

[via GitHub]

jlprat commented on code in PR #13723:
URL: https://github.com/apache/kafka/pull/13723#discussion_r1196222089


##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorConfigTest.java:
##########
@@ -43,7 +43,8 @@ protected TestMirrorConnectorConfig(Map<String, String> 
props) {
     @Test
     public void testSourceConsumerConfig() {
         Map<String, String> connectorProps = makeProps(
-                MirrorConnectorConfig.CONSUMER_CLIENT_PREFIX + 
"max.poll.interval.ms", "120000"
+                MirrorConnectorConfig.CONSUMER_CLIENT_PREFIX + 
"max.poll.interval.ms", "120000",
+                MirrorConnectorConfig.SOURCE_CLUSTER_PREFIX + 
"bootstrap.servers", "localhost:2345"

Review Comment:
   Nice to add a test to avoid the having the same mistake again



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org