cmccabe commented on PR #12331: URL: https://github.com/apache/kafka/pull/12331#issuecomment-1535924639
> @Hangleton : Agree that this change should be ideally confined to the Windows platform w/o any code change for others. Yeah. To be totally clear, it's OK to change the main code paths, but it really raises the stakes because then we want to understand that there haven't been performance or correctness regressions. @MPeli: I really do want this to get in eventually but in its current form it's very difficult to review. As a first step, how about splitting out just the FileRecords.java change, for example. If you want to do preallocation differently on windows, then explain how it will be different and why, and have a PR that just does that. Since preallocation seems to be working fine on other platforms this particular change could be put behind an isOsWindows check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
