divijvaidya commented on code in PR #13584:
URL: https://github.com/apache/kafka/pull/13584#discussion_r1170238988
##########
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala:
##########
@@ -65,6 +68,28 @@ class LogSegmentTest {
Utils.delete(logDir)
}
+ /**
+ * If the maximum offset beyond index, appended to the log section, it
throws LogSegmentOffsetOverflowException
+ */
+ @ParameterizedTest
+ @CsvSource(Array(
Review Comment:
Note that baseOffset can be `Long` but `largestOffset - baseOffset` should
be <= `Integer.MaxValue`. This case is missing from our test here.
Could we add the following test cases as well:
baseOffset is a number > Integer.MaxValue, largestOffset is a number >
Integer.MaxValue, such that `largestOffset - baseOffset` > Integer.MaxValue.
This will throw an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
