dajac commented on code in PR #13550:
URL: https://github.com/apache/kafka/pull/13550#discussion_r1169901603
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##########
@@ -835,6 +835,7 @@ public void handle(SyncGroupResponse syncResponse,
} else if (error == Errors.REBALANCE_IN_PROGRESS) {
log.info("SyncGroup failed: The group began another
rebalance. Need to re-join the group. " +
"Sent generation was {}", sentGeneration);
+ resetStateAndGeneration("member missed the rebalance",
true);
Review Comment:
> Regardlessly, it should still rejoin with its current partitions and
should continue to hold on to its partition if it is only 1 generation behind.
Are you sure about this? It seems to me that whenever the generation is
reset, all the partitions are lost and the member rejoins with no owned
partitions. Am I wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
