[ 
https://issues.apache.org/jira/browse/KAFKA-6814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447485#comment-16447485
 ] 

ASF GitHub Bot commented on KAFKA-6814:
---------------------------------------

huxihx opened a new pull request #4913: KAFKA-6814: Refine shown message when 
failing to delete groups
URL: https://github.com/apache/kafka/pull/4913
 
 
   https://issues.apache.org/jira/browse/KAFKA-6814
   
   When deleting a nonexistent group, exception message is as below:
   `The group id The group id does not exist was not found` which is very 
unfriendly. This patch will fix this misleading message in this case, and also 
cover deleting-not-empty-group as well.
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bad exception message for GroupIdNotFoundException/GroupNotEmptyException
> -------------------------------------------------------------------------
>
>                 Key: KAFKA-6814
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6814
>             Project: Kafka
>          Issue Type: Bug
>          Components: clients
>    Affects Versions: 1.1.0
>            Reporter: huxihx
>            Assignee: huxihx
>            Priority: Minor
>
> Both `GroupNotEmptyException` and `GroupIdNotFoundException` constructors 
> accept group id to deliver the exception message. However they can only be 
> created with a fixed string "The group id does not exist" or "The group is 
> not empty" which leads to a very unfriendly message when user failed to 
> delete consumer groups, as below:
> {code:java}
> java.util.concurrent.ExecutionException: 
> org.apache.kafka.common.errors.GroupIdNotFoundException: The group id The 
> group id does not exist was not found{code}
> group id got failed to be shown in the thrown exception. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to