emissionnebula commented on PR #13280: URL: https://github.com/apache/kafka/pull/13280#issuecomment-1502743377
> @ijuma @rondagostino : I feel like "persistent" should appear somewhere in the class names here. Perhaps you're right that it doesn't need to be in the short class name, but can we put the classes in a namespace that includes that word? So something like `org.apache.kafka.server.persistent`? Then we'd have `org.apache.kafka.server.persistent.ImmutableMap`, etc. > PMap or PersistentMap are also possible, but they can be confused with a map that persists the data I feel we should not only use the `persistent` in the package name but also name the class `PersistentMap`. Looks like persistent is not a new term, there was a 1989 [paper](https://www.cs.cmu.edu/~sleator/papers/making-data-structures-persistent.pdf) that coined this term. Clojure also defines them as PersistentVector and PersistentMap. Languages such as Scala, Elixir, and Haskell use the term persistent in the documentation as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
