CalvinConfluent commented on code in PR #13489:
URL: https://github.com/apache/kafka/pull/13489#discussion_r1159273764


##########
core/src/test/scala/unit/kafka/cluster/PartitionTest.scala:
##########
@@ -3167,7 +3307,8 @@ class PartitionTest extends AbstractPartitionTest {
     replicaId: Int,
     lastCaughtUpTimeMs: Long,
     logEndOffset: Long,
-    logStartOffset: Long
+    logStartOffset: Long,
+    brokerEpoch: Long = -2

Review Comment:
   Refactor to Option[long]. Using null to indicate that we need to verify the 
broker epoch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to