yashmayya commented on code in PR #13434:
URL: https://github.com/apache/kafka/pull/13434#discussion_r1153487940
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##########
@@ -866,4 +867,18 @@ public List<ConfigKeyInfo> connectorPluginConfig(String
pluginName) {
}
}
+ @Override
+ public void connectorOffsets(String connName, Callback<ConnectorOffsets>
cb) {
Review Comment:
I've tweaked the log statement and used a snapshot throughout for the
consistent view in the `AbstractHerder` method but I'm still not sure I
understand why we need to put this through the tick thread in the
`DistributedHerder`. I agree that there shouldn't be concerns about
unnecessarily blocking that thread but since the slight chance of concurrent
connector deletion exists in both scenarios, why would we want to do so for a
request that is non-mutating?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
