yashmayya commented on code in PR #13434:
URL: https://github.com/apache/kafka/pull/13434#discussion_r1151354145
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/HerderRequestHandler.java:
##########
@@ -66,17 +87,15 @@ public <T, U> T completeOrForwardRequest(FutureCallback<T>
cb,
Translator<T, U>
translator,
Boolean forward) throws
Throwable {
try {
- return cb.get(requestTimeoutMs, TimeUnit.MILLISECONDS);
- } catch (ExecutionException e) {
- Throwable cause = e.getCause();
-
- if (cause instanceof RequestTargetException) {
+ return completeRequest(cb);
+ } catch (Exception e) {
+ if (e instanceof RequestTargetException) {
Review Comment:
Oops, of course. My bad, I guess I was paying too much attention to keeping
things exactly as they were while porting over the changes from
`completeRequest` .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
