vcrfxia commented on code in PR #13449:
URL: https://github.com/apache/kafka/pull/13449#discussion_r1151140561
##########
streams/src/test/java/org/apache/kafka/streams/integration/VersionedKeyValueStoreIntegrationTest.java:
##########
@@ -361,6 +365,91 @@ public void shouldCreateGlobalTable() throws Exception {
}
}
+ @Test
+ public void shouldManualUpgradeFromNonVersionedToVersioned() throws
Exception {
+ // build non-versioned topology and start app
+ StreamsBuilder streamsBuilder = new StreamsBuilder();
+
+ streamsBuilder
+ .addStateStore(
+ Stores.timestampedKeyValueStoreBuilder(
Review Comment:
Yeah, as long as the changelog topic format is the same it'll work, which
means non-timestamped stores are eligible for upgrade too. Added an additional
test.
The docs PR just says "non-versioned" right now (no mention of timestamped
vs non-timestamped). I can add a line to make it clear that upgrading from both
timestamped and non-timestamped stores are supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
