cmccabe commented on code in PR #13368:
URL: https://github.com/apache/kafka/pull/13368#discussion_r1147881142
##########
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##########
@@ -597,6 +629,13 @@ public void run() throws Exception {
completionHandler.accept(null);
}
+ private void standardAclToMap(Map<ResourcePattern,
List<AccessControlEntry>> aclMap, StandardAcl acl) {
Review Comment:
How about `addStandardAclToMap` as a name? The current name makes it seem
like it's a 1:1 translation which of course it is not...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
