guozhangwang commented on PR #13380: URL: https://github.com/apache/kafka/pull/13380#issuecomment-1482028180
@philipnee I made a third pass on the PR, but it seems we still have a few issues not fixed: 1) https://github.com/apache/kafka/pull/13380#discussion_r1146961554, 2) https://github.com/apache/kafka/pull/13380#discussion_r1146963166, and 3) https://github.com/apache/kafka/pull/13380/files/d5013568e590768ccce6601bb271ff6a50bc1299#r1142698917. LMK what do you think? If you agree they should be fixed, while you fix them could you please also add the corresponding test cases to cover those scenarios? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
