[GitHub] [kafka] cmccabe commented on a diff in pull request #13438: KAFKA-14835: Create ControllerServerMetricsPublisher

[via GitHub]

cmccabe commented on code in PR #13438:
URL: https://github.com/apache/kafka/pull/13438#discussion_r1146927689


##########
core/src/main/scala/kafka/server/ControllerServer.scala:
##########
@@ -104,13 +106,15 @@ class ControllerServer(
   val socketServerFirstBoundPortFuture = new CompletableFuture[Integer]()
   var createTopicPolicy: Option[CreateTopicPolicy] = None
   var alterConfigPolicy: Option[AlterConfigPolicy] = None
+  @volatile var quorumControllerMetrics: QuorumControllerMetrics = _
   var controller: Controller = _
   var quotaManagers: QuotaManagers = _
   var clientQuotaMetadataManager: ClientQuotaMetadataManager = _
   var controllerApis: ControllerApis = _
   var controllerApisHandlerPool: KafkaRequestHandlerPool = _
   var migrationSupport: Option[ControllerMigrationSupport] = None
   def kafkaYammerMetrics: KafkaYammerMetrics = KafkaYammerMetrics.INSTANCE
+  val metadataPublishers: util.List[MetadataPublisher] = new 
CopyOnWriteArrayList[MetadataPublisher]()

Review Comment:
   ok, I'll just use array list for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org