Stephan14 commented on PR #13435: URL: https://github.com/apache/kafka/pull/13435#issuecomment-1479420158
Hey @divijvaidya First, this code https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala#L1330. The callback `responseCallback` will be called in another thread, so the lock about https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala#L248 does not take effect, is right? Second, about motivation, when the function `group.updateMember(knownStaticMember, oldProtocols, oldRebalanceTimeoutMs, oldSessionTimeoutMs, null)` is called, the `supportedProtocols` belongs to `GroupMetadata` is updated without lock, broker handles join group request and return `INCONSISTENT_GROUP_PROTOCOL` to client because `group.supportsProtocols(protocolType, MemberMetadata.plainProtocolSet(protocols))` is false -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
