jolshan commented on code in PR #13415:
URL: https://github.com/apache/kafka/pull/13415#discussion_r1140662378
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java:
##########
@@ -97,7 +98,11 @@ public <T> HttpResponse<T> httpRequest(String url, String
method, HttpHeaders he
public <T> HttpResponse<T> httpRequest(String url, String method,
HttpHeaders headers, Object requestBodyData,
TypeReference<T>
responseFormat,
SecretKey sessionKey, String
requestSignatureAlgorithm) {
- HttpClient client = httpClient();
+ // Only try to load SSL configs if we have to (see KAFKA-14816)
+ SslContextFactory sslContextFactory = url.startsWith("https://";)
Review Comment:
Is this the only way to know we need to use ssl? Seems a little strange we
are checking the url has https.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
