cmccabe commented on code in PR #13390:
URL: https://github.com/apache/kafka/pull/13390#discussion_r1135927103
##########
core/src/main/scala/kafka/server/ControllerServer.scala:
##########
@@ -131,11 +131,11 @@ class ControllerServer(
if (!maybeChangeStatus(SHUTDOWN, STARTING)) return
val startupDeadline = Deadline.fromDelay(time,
config.serverMaxStartupTimeMs, TimeUnit.MILLISECONDS)
try {
+ this.logIdent = new LogContext(s"[ControllerServer ${config.nodeId}]
").logPrefix()
info("Starting controller")
config.dynamicConfig.initialize(zkClientOpt = None)
maybeChangeStatus(STARTING, STARTED)
- this.logIdent = new LogContext(s"[ControllerServer id=${config.nodeId}]
").logPrefix()
Review Comment:
Yes, this use-case is a bit of a hack. (A hack that this PR didn't add!)
Basically we're forced to use the old Scala `Logging` trait unless we want
to rewrite all the BrokerServer stuff. But we want a nice-looking log prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
