cmccabe commented on code in PR #13355:
URL: https://github.com/apache/kafka/pull/13355#discussion_r1127208396
##########
raft/src/main/resources/common/message/QuorumStateData.json:
##########
@@ -16,10 +16,10 @@
{
"type": "data",
"name": "QuorumStateData",
- // Version 1 removes clusterId field.
- "validVersions": "0-1",
+ "validVersions": "0",
"flexibleVersions": "0+",
"fields": [
+ {"name": "ClusterId", "type": "string", "versions": "0+"},
Review Comment:
I am confused, why not just have ClusterId and `versions: "0"` (no plus sign
at the end)?
You can't change the past, but you certainly can create a new version
without this field if you really want.
I guess that also raises the question of how you determine the version. What
is the strategy there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
