kirktrue commented on code in PR #12813:
URL: https://github.com/apache/kafka/pull/12813#discussion_r1127204081
##########
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##########
@@ -324,11 +324,14 @@ public void disconnect(String nodeId) {
log.info("Client requested disconnect from node {}", nodeId);
selector.close(nodeId);
long now = time.milliseconds();
- cancelInFlightRequests(nodeId, now, abortedSends);
+ cancelInFlightRequests(nodeId, now, abortedSends, false);
connectionStates.disconnected(nodeId, now);
}
- private void cancelInFlightRequests(String nodeId, long now,
Collection<ClientResponse> responses) {
+ private void cancelInFlightRequests(String nodeId,
Review Comment:
I didn't want to introduce any inconsistency in this change as the rest of
the code doesn't follow that pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
