cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127176224
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -730,6 +744,45 @@ class DynamicThreadPool(server: KafkaBroker) extends
BrokerReconfigurable {
}
}
+ def getValue(config: KafkaConfig, name: String): Int = {
+ name match {
+ case KafkaConfig.NumIoThreadsProp => config.numIoThreads
+ case KafkaConfig.NumReplicaFetchersProp => config.numReplicaFetchers
+ case KafkaConfig.NumRecoveryThreadsPerDataDirProp =>
config.numRecoveryThreadsPerDataDir
+ case KafkaConfig.BackgroundThreadsProp => config.backgroundThreads
+ case n => throw new IllegalStateException(s"Unexpected config $n")
+ }
+ }
+}
+
+class ControllerDynamicThreadPool(controller: ControllerServer) extends
BrokerReconfigurable {
+
+ override def reconfigurableConfigs: Set[String] = {
+ DynamicThreadPool.ReconfigurableConfigs // common configs
Review Comment:
We probably shouldn't return `num.replica.fetchers`,
`num.recovery.threads.per.data.dir`, and `background.threads` here, since
they're not actually reconfigurable on the controller.
I don't think we have to fix that now, but I will file a JIRA to clean this
up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
