dajac commented on code in PR #12813:
URL: https://github.com/apache/kafka/pull/12813#discussion_r1123117911
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##########
@@ -641,7 +643,7 @@ private void completeBatch(ProducerBatch batch,
ProduceResponse.PartitionRespons
// thus it is not safe to reassign the sequence.
failBatch(batch, response, batch.attempts() < this.retries);
}
- if (error.exception() instanceof InvalidMetadataException) {
+ if (error.exception() instanceof InvalidMetadataException ||
error.exception() instanceof TimeoutException) {
Review Comment:
@kirktrue Do we need that new test if we remove the change in the Sender? We
could perhaps remove it and keep the PR focused on the initial change. This
would allow us to merge that first part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
