chia7712 commented on PR #13285: URL: https://github.com/apache/kafka/pull/13285#issuecomment-1450145297
@divijvaidya thanks for great feedback! > we have also have to ensure that deadlock doesn't occur when trying to acquire SocketServer lock and Processors lock. that is interesting. the mutation of processors is locked by `Acceptor` object. It means getting only lock of SocketServer is not safe when we plan to access the `processors`. We should require `Acceptor` lock also. In other words, this issue is related not only performance but also potential bug (concurrent issue). > we can choose to use a ConcurrentHashMap or a CopyOnWriteArrayList for storing processors. I will use `CopyOnWriteArrayList` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
