Hangleton commented on code in PR #13214: URL: https://github.com/apache/kafka/pull/13214#discussion_r1104482083
########## tools/src/main/java/org/apache/kafka/tools/MessageReader.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.tools; + +import org.apache.kafka.clients.producer.ProducerRecord; + +import java.io.InputStream; +import java.util.Properties; + +/** + * Typical implementations of this interface convert data from an {@link InputStream} received via + * {@link MessageReader#init(InputStream, Properties)} into a {@link ProducerRecord} instance on each + * invocation of `{@link MessageReader#readMessage()}`. + * + * This is used by the {@link ConsoleProducer}. + */ +public interface MessageReader { Review Comment: - For `MessageReader`: maybe we could provide a depreciation period until Apache Kafka 4.0 by exposing the class defined in [KIP-641](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866569) and keep the interface `kafka.common.MessageReader` inheriting from `org.apache.kafka.common.MessageReader` to avoid breaking the implementations above? The class `org.apache.kafka.common.MessageReader` could be put in the `clients` module (KIP-641 suggests to have `MessageReader` in this module since it is a public interface). - For the JMX Tool: maybe we could keep the existing class with a deprecation warning as you did in [PR-13195](https://github.com/apache/kafka/pull/13195) and create a shell and bat scripts as the public contract for the new class? - `kafka.tools.StateChangeLogMerger` could be removed if it isn't used as mentioned in [PR-13171](https://github.com/apache/kafka/pull/13171). - There is a missing BAT script for `FeatureCommand` although the shell script is defined. This could be added. - I skimmed through the other command/tool classes and all of them seem to be exposed via a script so that there shouldn't be any compatibility problem there? What other changes do we want to address? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
