C0urante commented on code in PR #13137: URL: https://github.com/apache/kafka/pull/13137#discussion_r1100587361
########## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/rest/resources/InternalMirrorResource.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.connect.mirror.rest.resources; + +import org.apache.kafka.connect.mirror.SourceAndTarget; +import org.apache.kafka.connect.runtime.Herder; +import org.apache.kafka.connect.runtime.rest.RestClient; +import org.apache.kafka.connect.runtime.rest.resources.InternalClusterResource; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import javax.ws.rs.NotFoundException; +import javax.ws.rs.Path; +import javax.ws.rs.core.Context; +import javax.ws.rs.core.UriInfo; +import java.util.List; +import java.util.Map; + +@Path("/{source}/{target}/connectors") +public class InternalMirrorResource extends InternalClusterResource { + + @Context + private UriInfo uriInfo; + + private static final Logger log = LoggerFactory.getLogger(InternalMirrorResource.class); + + private final Map<SourceAndTarget, Herder> herders; + + public InternalMirrorResource(Map<SourceAndTarget, Herder> herders, RestClient restClient) { + super(restClient); + this.herders = herders; + } + + @Override + protected Herder herderForRequest() { + String source = pathParam("source"); + String target = pathParam("target"); + Herder result = herders.get(new SourceAndTarget(source, target)); + if (result == null) { + log.debug("Failed to find herder for source '{}' and target '{}'", source, target); Review Comment: I was under the impression that throwing this would only cause the exception message to be present in the REST response (and presumably the logs for the worker that issued the request), but after revisiting the `ConnectExceptionMapper` class, it appears that we'll also log the exception at debug level on this worker. So yep, we can remove this 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
