cmccabe commented on code in PR #13183: URL: https://github.com/apache/kafka/pull/13183#discussion_r1093792394
########## server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java: ########## @@ -250,7 +250,7 @@ private void handleEvents() throws InterruptedException { continue; } else if (shuttingDown) { remove(eventContext); - toDeliver = new TimeoutException(); + toDeliver = new QueueClosingException(); Review Comment: Also we will need a test in `KafkaEventQueueTest` if you want to do this. I do wonder if this should be a separate PR ... queue changes have a way of being big. But I guess let's see if it impacts any other tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org