[
https://issues.apache.org/jira/browse/KAFKA-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419922#comment-16419922
]
ASF GitHub Bot commented on KAFKA-6707:
---------------------------------------
guozhangwang closed pull request #4762: [KAFKA-6707]The default value for
config of Type.LONG should be *L
URL: https://github.com/apache/kafka/pull/4762
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
index ecfcad80e81..644237509c9 100644
--- a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
+++ b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
@@ -468,12 +468,12 @@
COMMIT_INTERVAL_MS_DOC)
.define(CONNECTIONS_MAX_IDLE_MS_CONFIG,
ConfigDef.Type.LONG,
- 9 * 60 * 1000,
+ 9 * 60 * 1000L,
ConfigDef.Importance.LOW,
CommonClientConfigs.CONNECTIONS_MAX_IDLE_MS_DOC)
.define(METADATA_MAX_AGE_CONFIG,
ConfigDef.Type.LONG,
- 5 * 60 * 1000,
+ 5 * 60 * 1000L,
atLeast(0),
ConfigDef.Importance.LOW,
CommonClientConfigs.METADATA_MAX_AGE_DOC)
@@ -496,7 +496,7 @@
CommonClientConfigs.METRICS_RECORDING_LEVEL_DOC)
.define(METRICS_SAMPLE_WINDOW_MS_CONFIG,
Type.LONG,
- 30000,
+ 30000L,
atLeast(0),
Importance.LOW,
CommonClientConfigs.METRICS_SAMPLE_WINDOW_MS_DOC)
@@ -507,7 +507,7 @@
PARTITION_GROUPER_CLASS_DOC)
.define(POLL_MS_CONFIG,
Type.LONG,
- 100,
+ 100L,
Importance.LOW,
POLL_MS_DOC)
.define(RECEIVE_BUFFER_CONFIG,
@@ -559,12 +559,12 @@
CommonClientConfigs.SEND_BUFFER_DOC)
.define(STATE_CLEANUP_DELAY_MS_CONFIG,
Type.LONG,
- 10 * 60 * 1000,
+ 10 * 60 * 1000L,
Importance.LOW,
STATE_CLEANUP_DELAY_MS_DOC)
.define(WINDOW_STORE_CHANGE_LOG_ADDITIONAL_RETENTION_MS_CONFIG,
Type.LONG,
- 24 * 60 * 60 * 1000,
+ 24 * 60 * 60 * 1000L,
Importance.LOW,
WINDOW_STORE_CHANGE_LOG_ADDITIONAL_RETENTION_MS_DOC)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The default value for config of Type.LONG should be *L
> ------------------------------------------------------
>
> Key: KAFKA-6707
> URL: https://issues.apache.org/jira/browse/KAFKA-6707
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Affects Versions: 1.2.0
> Reporter: JieFang.He
> Assignee: JieFang.He
> Priority: Major
>
> h1. The default value for config of Type.LONG should be *L
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
