sgn2607 commented on code in PR #11748:
URL: https://github.com/apache/kafka/pull/11748#discussion_r1083630069


##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java:
##########
@@ -169,6 +172,7 @@ public String version() {
         return listConsumerGroupOffsets(group).entrySet().stream()
             .filter(x -> shouldCheckpointTopic(x.getKey().topic()))
             .map(x -> checkpoint(group, x.getKey(), x.getValue()))
+            .flatMap(o -> o.map(Stream::of).orElseGet(Stream::empty)) // do 
not emit checkpoints for partitions that don't have offset-syncs

Review Comment:
   @dadufour I'm facing similar issue w.r.to the consumer group offset handling 
during the failback and thank you for lifting it up in the Strimzi forum that 
help me land up in this thread.  @mimaison I thought I shall check if there is 
a KIP to handle this behavior in MM2 or is it already fixed? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to