dajac commented on code in PR #12902:
URL: https://github.com/apache/kafka/pull/12902#discussion_r1070928680
##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##########
@@ -470,4 +470,45 @@ class GroupCoordinatorAdapter(
expireTimestamp = expireTimestamp
)
}
+
+ override def deleteOffsets(
+ context: RequestContext,
+ request: OffsetDeleteRequestData,
+ bufferSupplier: BufferSupplier
+ ): CompletableFuture[OffsetDeleteResponseData] = {
+ val future = new CompletableFuture[OffsetDeleteResponseData]()
+
+ val partitions = mutable.ArrayBuffer[TopicPartition]()
+ request.topics.forEach { topic =>
+ topic.partitions.forEach { partition =>
+ partitions += new TopicPartition(topic.name, partition.partitionIndex)
+ }
+ }
+
+ val (groupError, topicPartitionResults) = coordinator.handleDeleteOffsets(
+ request.groupId,
+ partitions,
+ RequestLocal(bufferSupplier)
+ )
+
+ if (groupError != Errors.NONE) {
+ future.completeExceptionally(groupError.exception)
+ } else {
+ val response = new OffsetDeleteResponseData()
+ topicPartitionResults.forKeyValue { (topicPartition, error) =>
+ var topic = response.topics.find(topicPartition.topic)
Review Comment:
Yeah, that's right. In the schema definition, you can specify that you want
a map like data structure instead of a list. This is done by specifying the
"mapKey" in the spec.
As Justine said, this was done before this patch so I just kept it as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
