ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1070539477
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -70,7 +70,9 @@ class DelayedOperations(topicPartition: TopicPartition,
def numDelayedDelete: Int = deleteRecords.numDelayed
}
-object Partition extends KafkaMetricsGroup {
+object Partition {
+ private val metricsGroup = new KafkaMetricsGroup(classOf[Partition])
Review Comment:
This works for some classes, but some other (e.g. `KafkaBroker`,
`KafkaController`) already have the `metrics` field. Maybe let's keep the
suffix for consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
