andymg3 opened a new pull request, #13104:
URL: https://github.com/apache/kafka/pull/13104

   ### JIRA
   https://issues.apache.org/jira/browse/KAFKA-14612
   
   ### Details
   Makes sure we emit `ConfigRecord`s for a topic iff it actually gets created. 
Currently, we might emit `ConfigRecord`s even if the topic creation fails later 
in the `createTopics` method.
   
   ### Testing
   Enhanced pre-existing test 
`ReplicationControlManagerTest.testCreateTopicsWithConfigs`. I ran the tests 
without the changes to `ReplicationControlManager` and made sure each assertion 
ends up failing.
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to