divijvaidya commented on code in PR #13094:
URL: https://github.com/apache/kafka/pull/13094#discussion_r1064594474
##########
clients/src/test/java/org/apache/kafka/clients/FetchSessionHandlerTest.java:
##########
@@ -320,7 +315,7 @@ public void testDoubleBuild() {
try {
builder.build();
fail("Expected calling build twice to fail.");
- } catch (Throwable t) {
+ } catch (NullPointerException npe) {
Review Comment:
NPE is a weird way of enforcing idempotency for build()! While you are in
this code base could we add a javadoc to build() to clarify this expectation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
