philipnee commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057824516
########## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ########## @@ -150,6 +150,10 @@ import static org.junit.jupiter.api.Assertions.assertTrue; import static org.junit.jupiter.api.Assertions.fail; +/** + * Note to future authors in this class. If you close the consumer, close with DURATION.ZERO to reduce the duration of the + * test. Review Comment: I think 80 is a bit short (i've heard the convention came from punch card, hope we aren't doing that), and in most cases, i think (in the client code base) most comments are definitely longer than 80. In my editor, I use 100, though i sometimes go above that limit for cases like this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
