showuon commented on code in PR #13005: URL: https://github.com/apache/kafka/pull/13005#discussion_r1052957825
########## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorUtilsTest.java: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.connect.mirror; + +import org.apache.kafka.clients.admin.Admin; +import org.apache.kafka.clients.admin.CreateTopicsResult; +import org.apache.kafka.common.KafkaFuture; +import org.apache.kafka.common.errors.ClusterAuthorizationException; +import org.apache.kafka.common.errors.TopicExistsException; +import org.apache.kafka.connect.errors.ConnectException; +import org.junit.jupiter.api.Test; + +import java.util.Collections; +import java.util.Map; +import java.util.concurrent.ExecutionException; + +import static org.junit.jupiter.api.Assertions.assertTrue; +import static org.junit.jupiter.api.Assertions.fail; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +public class MirrorUtilsTest { + + private static final String TOPIC = "topic"; + + private final Admin admin = mock(Admin.class); + private final CreateTopicsResult ctr = mock(CreateTopicsResult.class); + @SuppressWarnings("unchecked") + private final KafkaFuture<Void> future = mock(KafkaFuture.class); + + @Test + public void testCreateCompactedTopic() throws Exception { + Map<String, KafkaFuture<Void>> values = Collections.singletonMap(TOPIC, future); + when(future.get()).thenReturn(null); + when(ctr.values()).thenReturn(values); + when(admin.createTopics(any(), any())).thenReturn(ctr); + MirrorUtils.createCompactedTopic(TOPIC, (short) 1, (short) 1, admin); + } + + @Test + public void testCreateCompactedTopicAlreadyExists() throws Exception { + Map<String, KafkaFuture<Void>> values = Collections.singletonMap(TOPIC, future); + when(future.get()).thenThrow(new ExecutionException(new TopicExistsException("topic exists"))); + when(ctr.values()).thenReturn(values); + when(admin.createTopics(any(), any())).thenReturn(ctr); + MirrorUtils.createCompactedTopic(TOPIC, (short) 1, (short) 1, admin); + } + + @Test + public void testCreateCompactedTopicFails() throws Exception { + Map<String, KafkaFuture<Void>> values = Collections.singletonMap(TOPIC, future); + when(future.get()).thenThrow(new ExecutionException(new ClusterAuthorizationException("not authorized"))); + when(ctr.values()).thenReturn(values); + when(admin.createTopics(any(), any())).thenReturn(ctr); + try { + MirrorUtils.createCompactedTopic(TOPIC, (short) 1, (short) 1, admin); + fail("Should have thrown"); + } catch (ConnectException ce) { + assertTrue(ce.getCause() instanceof ExecutionException); + assertTrue(ce.getCause().getCause() instanceof ClusterAuthorizationException); + } + } Review Comment: nit: maybe use `assertThrows` here? It simplify the tests without try/catch. ``` Throwable ce = assertThrows(ConnectException.class, () -> MirrorUtils.createCompactedTopic(TOPIC, (short) 1, (short) 1, admin), "Should have exception thrown"); assertTrue(ce.getCause() instanceof ExecutionException); assertTrue(ce.getCause().getCause() instanceof ClusterAuthorizationException); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
