jolshan commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1052765746
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -1397,77 +1397,172 @@ class KafkaApis(val requestChannel: RequestChannel,
requestHelper.sendResponseMaybeThrottle(request, createResponse)
}
- private def handleOffsetFetchRequestBetweenV1AndV7(request:
RequestChannel.Request): Unit = {
- val header = request.header
+ private def handleOffsetFetchRequestBetweenV1AndV7(request:
RequestChannel.Request): CompletableFuture[Unit] = {
Review Comment:
These two methods are a lot cleaner now. Is the main difference how the
requests are formatted?
Ie, the v8 request is structured by group?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
