ijuma commented on code in PR #13013: URL: https://github.com/apache/kafka/pull/13013#discussion_r1051520754
########## storage/src/main/java/org/apache/kafka/server/log/remote/storage/ClassLoaderAwareRemoteStorageManager.java: ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.log.remote.storage; + +import java.io.IOException; +import java.io.InputStream; +import java.util.Map; + +/** + * A wrapper class of {@link RemoteStorageManager} that sets the context class loader when calling the respective + * methods. + */ +public class ClassLoaderAwareRemoteStorageManager implements RemoteStorageManager { + + private final RemoteStorageManager delegate; + private final ClassLoader rsmClassLoader; + + public ClassLoaderAwareRemoteStorageManager(RemoteStorageManager rsm, ClassLoader rsmClassLoader) { + this.delegate = rsm; + this.rsmClassLoader = rsmClassLoader; + } + + public RemoteStorageManager delegate() { + return delegate; + } + + @Override + public void configure(Map<String, ?> configs) { + ClassLoader originalClassLoader = Thread.currentThread().getContextClassLoader(); + Thread.currentThread().setContextClassLoader(rsmClassLoader); + try { + delegate.configure(configs); + } finally { + Thread.currentThread().setContextClassLoader(originalClassLoader); + } + } + + @Override + public void close() throws IOException { + ClassLoader originalClassLoader = Thread.currentThread().getContextClassLoader(); + Thread.currentThread().setContextClassLoader(rsmClassLoader); + try { + delegate.close(); + } finally { + Thread.currentThread().setContextClassLoader(originalClassLoader); + } + } + + private <T> T withClassLoader(RemoteStorageAction<T> action) throws RemoteStorageException { Review Comment: Perhaps a better option would be an interface like: ```java interface ClassLoaderAction<T, E extends Exception> { T execute() throws E; } ``` Then you can use it from `close` too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
