ijuma commented on code in PR #12993: URL: https://github.com/apache/kafka/pull/12993#discussion_r1051437571
########## storage/src/main/java/org/apache/kafka/server/log/internals/OffsetPosition.java: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.log.internals; + +/** + * The mapping between a logical log offset and the physical position + * in some log file of the beginning of the message set entry with the + * given offset. + */ +public final class OffsetPosition implements IndexEntry { + public final long offset; + public final int position; + + public OffsetPosition(long offset, int position) { + this.offset = offset; + this.position = position; + } + + @Override + public long indexKey() { + return offset; + } + + @Override + public long indexValue() { + return position; + } + + @Override + public boolean equals(Object o) { + if (this == o) + return true; + if (o == null || getClass() != o.getClass()) + return false; + + OffsetPosition that = (OffsetPosition) o; + + return offset == that.offset + && position == that.position; + } + + @Override + public int hashCode() { Review Comment: Correct, case classes automatically generate `toString`, `hashCode` and `equals` and hence why I did the same here. However, the underlying implementation is not the same, but that's not an issue for us. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
