PhantomMaa commented on PR #12997: URL: https://github.com/apache/kafka/pull/12997#issuecomment-1356095914
Thanks for your reply. I agree that the `KafkaServer` is not designed for extend, attempt to replace the `LogManager` by override a `createLogManager`, maybe not a permanently method. As your said, a KIP is needed to propose a complete approache that specially focus on which components can be extended in `KafkaServer`. Design an interface describe which components support extend is obviously a better way. Before an api or interface be provided, allow to extend an object's method properly can be a temporary way with less drawback. At least is better than that fork a standalone repository, then modify with the code. The extend way is just add a kafka-core.jar, then override inside classes. Except the extend side, provide a `createLogManager` method is coincide with `createReplicaManager` below those code. It's also a good style only by the readability. Further on, only this modification is negligible, we could meet more problems in the way to extend `LogManager`. In that time, i am willing to provide a comprehensive plan as a KIP to resolve the extension problem. Thank you both again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
