tikimims commented on code in PR #12941:
URL: https://github.com/apache/kafka/pull/12941#discussion_r1042949185
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java:
##########
@@ -232,9 +232,12 @@ public String toString() {
public static final String EXACTLY_ONCE_SOURCE_SUPPORT_CONFIG =
"exactly.once.source.support";
public static final String EXACTLY_ONCE_SOURCE_SUPPORT_DOC = "Whether to
enable exactly-once support for source connectors in the cluster "
- + "by using transactions to write source records and their source
offsets, and by proactively fencing out old task generations before bringing up
new ones. ";
- // TODO: https://issues.apache.org/jira/browse/KAFKA-13709
- // + "See the exactly-once source support documentation at
[add docs link here] for more information on this feature.";
+ + "by using transactions to write source records and their source
offsets, and by proactively fencing out old task generations before bringing up
new ones.\n"
+ + "To enable exactly-once source support on a new cluster, set
this property to '" + ExactlyOnceSourceSupport.ENABLED + "'. "
+ + "To enable support on an existing cluster, first set to '" +
ExactlyOnceSourceSupport.PREPARING + "' on every worker in the cluster, "
+ + "then set to '" + ExactlyOnceSourceSupport.ENABLED + "'. A
rolling upgrade may be used for both changes. "
+ + "See the <a
href=\"https://kafka.apache.org/documentation.html#connect_exactlyoncesource\";>exactly-once
source support documentation</a> "
+ + "for more information on this feature.";
Review Comment:
Recommend reordering this sentence to: "For more information on this
feature, see the <a href..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
