ableegoldman commented on code in PR #12962:
URL: https://github.com/apache/kafka/pull/12962#discussion_r1042911388
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java:
##########
@@ -112,6 +113,56 @@ public final class AssignmentTestUtils {
private AssignmentTestUtils() {}
+ public static AssignmentConfigs getConfigsWithLagWithStandby(final long
acceptableRecoveryLagMs) {
Review Comment:
There were a HUGE number of individual calls to the `AssignmentConfigs`
constructor in the assignor-related tests, which means we'd have to update a
ridiculous number of lines just to add a single config to this simple container
class. There are better ways to do this right but I tried to help the situation
without completely blowing up the scope, so that's what this is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
