philipnee commented on code in PR #12862:
URL: https://github.com/apache/kafka/pull/12862#discussion_r1042905241
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##########
@@ -50,57 +49,83 @@ public class DefaultBackgroundThread extends KafkaThread {
private final Logger log;
private final BlockingQueue<ApplicationEvent> applicationEventQueue;
private final BlockingQueue<BackgroundEvent> backgroundEventQueue;
- private final ConsumerNetworkClient networkClient;
- private final SubscriptionState subscriptions;
private final ConsumerMetadata metadata;
- private final Metrics metrics;
private final ConsumerConfig config;
+ // empty if groupId is null
+ private final Optional<CoordinatorRequestManager> coordinatorManager;
Review Comment:
Let's reconsider this later? I'm not sure if that would simplify the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
