cmccabe opened a new pull request, #12958: URL: https://github.com/apache/kafka/pull/12958
Split out the logic for applying dynamic configurations to a KafkaConfig object from BrokerMetadataPublisher into a new class, DynamicConfigPublisher. This will allow the ControllerServer to also run this code, in a follow-up change. Create separate KafkaConfig objects in BrokerServer versus ControllerServer. This is necessary because the controller will apply configuration changes as soon as its raft client catches up to the high water mark, whereas the broker will wait for the active controller to acknowledge it has caught up in a heartbeat response. So when running in combined mode, we want two separate KafkaConfig objects that are changed at different times. Minor changes: improve the error message when catching up broker metadata fails. Fix incorrect indentation in checkstyle/import-control.xml. Invoke AppInfoParser.unregisterAppInfo from SharedServer.stop so that it happens only when both the controller and broker have shut down. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
