divijvaidya commented on PR #12940: URL: https://github.com/apache/kafka/pull/12940#issuecomment-1338178759
I am moving this PR to draft mode. Please hold the review. I need to add a proof here that the when we relax synchronisation amongst operations in this class by allowing concurrent access (e.g. add/removeSensors can operate concurrently), we are not violating any semantics. I will also make some changes to `metrics` entity in this class. Currently, we acquire a coarse grained lock on the entire class and I will explore whether we can divide it into finer locks (or allow concurrent access) with `metrics` entity, `sensors` entity and `childrenSensors` entity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
