jonathan-albrecht-ibm commented on code in PR #12343:
URL: https://github.com/apache/kafka/pull/12343#discussion_r1039696317
##########
clients/src/test/java/org/apache/kafka/common/utils/JavaTest.java:
##########
@@ -46,9 +49,22 @@ public void testIsIBMJdk() {
assertTrue(Java.isIbmJdk());
}
+ @Test
+ public void testIsIBMJdkSemeru() {
+ System.setProperty("java.vendor", "Oracle Corporation");
+ assertFalse(Java.isIbmJdkSemeru());
+ System.setProperty("java.vendor", "IBM Corporation");
+ System.setProperty("java.runtime.name", "Java(TM) SE Runtime
Environment");
+ assertFalse(Java.isIbmJdkSemeru());
+ System.setProperty("java.vendor", "IBM Corporation");
+ System.setProperty("java.runtime.name", "IBM Semeru Runtime Certified
Edition");
+ assertTrue(Java.isIbmJdkSemeru());
Review Comment:
The original property values are saved and restored in the `before()` and
`after()` methods (annotated with `@BeforeEach` and `@AfterEach`) so I think
each test method will start with the JVM's property values. Let me know if I'm
missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
