OmniaGM commented on code in PR #12858:
URL: https://github.com/apache/kafka/pull/12858#discussion_r1030668387
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -1992,6 +1992,186 @@ class KafkaApisTest {
testListOffsetFailedGetLeaderReplica(Errors.UNKNOWN_TOPIC_OR_PARTITION)
}
+ @Test
+ def testHandleDeleteGroups(): Unit = {
+ val deleteGroupsRequest = new DeleteGroupsRequestData()
+ .setGroupsNames(List(
+ "group-1",
+ "group-2",
+ "group-3"
+ ).asJava)
+
+ val requestChannelRequest = buildRequest(new
DeleteGroupsRequest.Builder(deleteGroupsRequest).build())
+
+ val expectedRequestContext = new GroupCoordinatorRequestContext(
+ ApiKeys.DELETE_GROUPS.latestVersion,
+ requestChannelRequest.context.clientId,
+ requestChannelRequest.context.clientAddress,
+ RequestLocal.NoCaching.bufferSupplier
+ )
+
+ val future = new
CompletableFuture[DeleteGroupsResponseData.DeletableGroupResultCollection]()
+ when(newGroupCoordinator.deleteGroups(
+ ArgumentMatchers.eq(expectedRequestContext),
+ ArgumentMatchers.eq(List("group-1", "group-2", "group-3").asJava)
+ )).thenReturn(future)
+
+ createKafkaApis().handleDeleteGroupsRequest(
+ requestChannelRequest,
+ RequestLocal.NoCaching
+ )
+
+ val results = new
DeleteGroupsResponseData.DeletableGroupResultCollection(List(
+ new DeleteGroupsResponseData.DeletableGroupResult()
+ .setGroupId("group-1")
+ .setErrorCode(Errors.NONE.code),
+ new DeleteGroupsResponseData.DeletableGroupResult()
+ .setGroupId("group-2")
+ .setErrorCode(Errors.NOT_CONTROLLER.code),
+ new DeleteGroupsResponseData.DeletableGroupResult()
+ .setGroupId("group-3")
+ .setErrorCode(Errors.UNKNOWN_SERVER_ERROR.code),
+ ).iterator.asJava)
+
+ future.complete(results)
+
+ val expectedDeleteGroupsResponse = new DeleteGroupsResponseData()
+ .setResults(results)
+
+ val capturedResponse = verifyNoThrottling(requestChannelRequest)
+ val response = capturedResponse.getValue.asInstanceOf[DeleteGroupsResponse]
+ assertEquals(expectedDeleteGroupsResponse, response.data)
+ }
+
+ @Test
+ def testHandleDeleteGroupsFutureFailed(): Unit = {
+ val deleteGroupsRequest = new DeleteGroupsRequestData()
+ .setGroupsNames(List(
+ "group-1",
+ "group-2",
+ "group-3"
+ ).asJava)
+
+ val requestChannelRequest = buildRequest(new
DeleteGroupsRequest.Builder(deleteGroupsRequest).build())
+
+ val expectedRequestContext = new GroupCoordinatorRequestContext(
+ ApiKeys.DELETE_GROUPS.latestVersion,
+ requestChannelRequest.context.clientId,
+ requestChannelRequest.context.clientAddress,
+ RequestLocal.NoCaching.bufferSupplier
+ )
+
+ val future = new
CompletableFuture[DeleteGroupsResponseData.DeletableGroupResultCollection]()
+ when(newGroupCoordinator.deleteGroups(
+ ArgumentMatchers.eq(expectedRequestContext),
+ ArgumentMatchers.eq(List("group-1", "group-2", "group-3").asJava)
+ )).thenReturn(future)
+
+ createKafkaApis().handleDeleteGroupsRequest(
+ requestChannelRequest,
+ RequestLocal.NoCaching
+ )
+
+ future.completeExceptionally(Errors.NOT_CONTROLLER.exception)
+
+ val expectedDeleteGroupsResponse = new DeleteGroupsResponseData()
+ .setResults(new
DeleteGroupsResponseData.DeletableGroupResultCollection(List(
+ new DeleteGroupsResponseData.DeletableGroupResult()
+ .setGroupId("group-1")
+ .setErrorCode(Errors.NOT_CONTROLLER.code),
+ new DeleteGroupsResponseData.DeletableGroupResult()
+ .setGroupId("group-2")
+ .setErrorCode(Errors.NOT_CONTROLLER.code),
+ new DeleteGroupsResponseData.DeletableGroupResult()
+ .setGroupId("group-3")
+ .setErrorCode(Errors.NOT_CONTROLLER.code),
+ ).iterator.asJava))
+
+ val capturedResponse = verifyNoThrottling(requestChannelRequest)
+ val response = capturedResponse.getValue.asInstanceOf[DeleteGroupsResponse]
+ assertEquals(expectedDeleteGroupsResponse, response.data)
+ }
+
+ @Test
+ def testHandleDeleteGroupsAuthenticationFailed(): Unit = {
+ val deleteGroupsRequest = new DeleteGroupsRequestData()
+ .setGroupsNames(List(
+ "group-1",
+ "group-2",
+ "group-3"
+ ).asJava)
+
+ val requestChannelRequest = buildRequest(new
DeleteGroupsRequest.Builder(deleteGroupsRequest).build())
+
+ val authorizer: Authorizer = mock(classOf[Authorizer])
+
+ def makeDeleteAction(groupId: String): Action = {
+ new Action(
+ AclOperation.DELETE,
+ new ResourcePattern(ResourceType.GROUP, groupId, PatternType.LITERAL),
+ 1,
+ true,
+ true
+ )
+ }
+
+ when(authorizer.authorize(
+ any[RequestContext],
+ ArgumentMatchers.eq(Seq(
+ makeDeleteAction("group-3"),
+ makeDeleteAction("group-2"),
+ makeDeleteAction("group-1"),
+ ).asJava)
+ )).thenReturn(Seq(
+ AuthorizationResult.ALLOWED,
+ AuthorizationResult.ALLOWED,
+ AuthorizationResult.DENIED
+ ).asJava)
+
+ val expectedRequestContext = new GroupCoordinatorRequestContext(
+ ApiKeys.DELETE_GROUPS.latestVersion,
+ requestChannelRequest.context.clientId,
+ requestChannelRequest.context.clientAddress,
+ RequestLocal.NoCaching.bufferSupplier
+ )
+
+ val future = new
CompletableFuture[DeleteGroupsResponseData.DeletableGroupResultCollection]()
+ when(newGroupCoordinator.deleteGroups(
+ ArgumentMatchers.eq(expectedRequestContext),
+ ArgumentMatchers.eq(List("group-2", "group-3").asJava)
+ )).thenReturn(future)
+
+ createKafkaApis(authorizer = Some(authorizer)).handleDeleteGroupsRequest(
+ requestChannelRequest,
+ RequestLocal.NoCaching
+ )
+
+ future.complete(new
DeleteGroupsResponseData.DeletableGroupResultCollection(List(
+ new DeleteGroupsResponseData.DeletableGroupResult()
+ .setGroupId("group-2")
+ .setErrorCode(Errors.NONE.code),
+ new DeleteGroupsResponseData.DeletableGroupResult()
+ .setGroupId("group-3")
+ .setErrorCode(Errors.NONE.code)
+ ).iterator.asJava))
+
+ val expectedDeleteGroupsResponse = new DeleteGroupsResponseData()
+ .setResults(new
DeleteGroupsResponseData.DeletableGroupResultCollection(List(
+ new DeleteGroupsResponseData.DeletableGroupResult()
Review Comment:
same here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
