Cerchie opened a new pull request, #12893:
URL: https://github.com/apache/kafka/pull/12893

   As a result of "[14260: InMemoryKeyValueStore iterator still throws 
ConcurrentModificationException](https://issues.apache.org/jira/browse/KAFKA-14260)",
 I'm adding `synchronized` to `prefixScan` as an alternative to going back to 
the `ConcurrentSkipList`. 
   
   I've read up on testing multi-threaded behavior and I believe it's best to 
leave the testing as it is for now as testing whether `synchronized` works 
doesn't always work. I did make sure `./gradlew test` was green on my branch. 
Happy to be corrected here. 
   
   This is my first PR. As of the 
[guidelines](https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes),
 I  that the contribution is my original work and that I license the work to 
the project under the project's open source license. I see that I also need to 
make a build trigger request, @ableegoldman I would appreciate one please :) 
   
   I do not believe this requires a documentation update as it is just bringing 
a method up to standard. Again, happy to help out if it turns out otherwise. 
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to