andymg3 opened a new pull request, #12892:
URL: https://github.com/apache/kafka/pull/12892

   ### JIRA
   https://issues.apache.org/jira/browse/KAFKA-14386
   
   ### Summary
   This changes the `ReplicaPlacer` interface to return a class instead of a 
list of list of integers. There are two reasons for the suggestion. First, as 
mentioned in the JIRA, it will make the interface, arguably, a bit more 
readable and understandable by explicitly modeling the idea of topic and 
partition. Second and more importantly, it makes the interface more extendable 
in the future. Right now it would be challenging to add more metadata to the 
response. By having classes, we can easily add fields to them without 
breaking/changing the interface. For example, in the CreatePartitions RPC we 
are adding partitions to an existing topic and we might want to add some 
metadata to response making it clear which partition the assignment starts at 
which could look something like:
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to