rondagostino commented on code in PR #12856:
URL: https://github.com/apache/kafka/pull/12856#discussion_r1023303714
##########
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala:
##########
@@ -319,7 +345,7 @@ class BrokerToControllerRequestThread(
val requestIter = requestQueue.iterator()
while (requestIter.hasNext) {
val request = requestIter.next
- if (currentTimeMs - request.createdTimeMs >= retryTimeoutMs) {
+ if (currentTimeMs - request.createdTimeMs >=
requestThreadRetryTimeoutMs) {
Review Comment:
This is the only place this particular retry timeout is used. It is not
clear to me how the semantics of this timeout and the network client timeout
differ and why the values are used differently (specifically,
AlterParticionManager currently sets Long.MAX_VALUE for this timeout but uses
`controller.socket.timeout.ms` for the network client timeout).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
